Scratch

GeonoTRON2000 wrote:

I realize that Antidote is an outdated topic, but I've been thinking, and realized how repetitive it is.  It is possible to summarize all of the code into one line (with only one semicolon per line, otherwise, that's cheap  .)  I only included the img tag, but you get the idea.  More tags can be added can be added by adding .replace(regex, output) before the semicolon.

Code:

document.getElementsByTagName("body")[0].innerHTML = document.getElementsByTagName("body")[0].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/g, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />");

If you still have antidote installed, THEN GET RID OF IT! It causes weird thing's to happen to your computer.

GeonoTRON2000 wrote:

joletole wrote:

GeonoTRON2000 wrote:

I realize that Antidote is an outdated topic, but I've been thinking, and realized how repetitive it is.  It is possible to summarize all of the code into one line (with only one semicolon per line, otherwise, that's cheap  .)  I only included the img tag, but you get the idea.  More tags can be added can be added by adding .replace(regex, output) before the semicolon.

Code:

document.getElementsByTagName("body")[0].innerHTML = document.getElementsByTagName("body")[0].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/g, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />");

If you still have antidote installed, THEN GET RID OF IT! It causes weird thing's to happen to your computer.

Nobody still does.  I'm just saying this one is basically a one-line version.

From what I see in it, it will mess up the browser, because replacing document.body.innerHTML often has undesired results.

GeonoTRON2000 wrote:

jvvg wrote:

GeonoTRON2000 wrote:

Nobody still does.  I'm just saying this one is basically a one-line version.

From what I see in it, it will mess up the browser, because replacing document.body.innerHTML often has undesired results.

1) That's what the original antidote script does
2) That only happens when the website uses advanced tactics, also using javascript, which most forum softwares don't do.

1. The original antidote cause my page to glitch up a bit with some JS stuff.
2. Even so, it's safer to do do it element by element.

GeonoTRON2000 wrote:

jvvg wrote:

GeonoTRON2000 wrote:

1) That's what the original antidote script does
2) That only happens when the website uses advanced tactics, also using javascript, which most forum softwares don't do.

1. The original antidote cause my page to glitch up a bit with some JS stuff.
2. Even so, it's safer to do do it element by element.

Try doing that in one line. 

Some things need to be more than one line.

(mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}

Why did you put {1} there? It serves no purpose.

Some things need to be more than one line.

you();!function(){can()}('put');multiple();statements();on(1);'line' in JavaScript;

There's no real limit on line length in JavaScript; when minified, the jQuery is one line.

Last edited by nXIII (2012-12-03 20:34:28)

@nXIII:
I meant to say some things should be more than one line, not that they need to be.

GeonoTRON2000 wrote:

Here's (roughly) what jvvg is proposing:

Code:

var posts = document.getElementsByClassName("postright");
for (var i = 0; i < posts.length; i++) {
  posts[i].innerHTML = posts[i].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/gi, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />");
}

You'll notice there are 4 lines. 

[].forEach.call(document.querySelectorAll('.postright'),function(p){p.innerHTML=p.innerHTML.replace(/\[img](ht|f)tps?:\/\/\S+\[\/img]/gi, '<img style=max-width:510px src="$1" alt="$1">');});

One line.

Last edited by nXIII (2012-12-03 21:21:53)

GeonoTRON2000 wrote:

nXIII wrote:

GeonoTRON2000 wrote:

Here's (roughly) what jvvg is proposing:

Code:

var posts = document.getElementsByClassName("postright");
for (var i = 0; i < posts.length; i++) {
  posts[i].innerHTML = posts[i].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/gi, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />");
}

You'll notice there are 4 lines. 

Code:

[].forEach.call(document.querySelectorAll('.postright'),function(p){p.innerHTML=p.innerHTML.replace(/\[url](ht|f)tps?:\/\/\S+\[\/img]/gi, '<img style=max-width:510px src="$1" alt="$1">');});

One line.

or just:

Code:

for (var i = 0; i < document.getElementsByClassName("postright").length; i++) { document.getElementsByClassName("postright")[i].innerHTML = document.getElementsByClassName("postright")[i].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/gi, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />"); }

That's longer.

nXIII wrote:

GeonoTRON2000 wrote:

nXIII wrote:

Code:

[].forEach.call(document.querySelectorAll('.postright'),function(p){p.innerHTML=p.innerHTML.replace(/\[url](ht|f)tps?:\/\/\S+\[\/img]/gi, '<img style=max-width:510px src="$1" alt="$1">');});

One line.

or just:

Code:

for (var i = 0; i < document.getElementsByClassName("postright").length; i++) { document.getElementsByClassName("postright")[i].innerHTML = document.getElementsByClassName("postright")[i].innerHTML.replace(/\[img\]((mailto\:|(news|(ht|f)tp(s?))\:\/\/){1}\S+)\[\/img\]/gi, "<img style=\"max-width: 510px;\" src=\"$1\" alt=\"$1\" />"); }

That's longer.

But easier to understand.

@MathWizz: cool

nXIII wrote:

GeonoTRON2000 wrote:

nXIII wrote:

That's longer.

But easier to understand.

Mine is much less repetitive and uses a shorter iterator. That's doesn't make it harder to understand.

EDIT: Also, yours fetches the list of elements three times in every loop iteration. Mine fetches them once.

Oh, no, you lost 2 bytes of RAM... 

MathWizz wrote:

GeonoTRON2000 wrote:

nXIII wrote:

Mine is much less repetitive and uses a shorter iterator. That's doesn't make it harder to understand.

EDIT: Also, yours fetches the list of elements three times in every loop iteration. Mine fetches them once.

Oh, no, you lost 2 bytes of RAM... 

No, it makes the loop slower, is very bad practice, and makes the script longer. You have no excuse.

I don't need an excuse.  I didn't forget my homework.