Scratch

http://scratch.mit.edu/projects/clubby789/2910966

Hi!
Firstly, instead of your 'forever if:' code for each of the houses, you'd do better to use:

when gf clicked

forever  

if <touching [Sprite1 v]?> 

change [Money v] by (House3)

set [House3 v] to [0]

change [Collected v] by (-1)

stop script

end

end

or

when gf clicked

wait until <touching [Sprite1 v]?>

change [Money v] by (House2)

set [House2 v] to [0]

change [Collected v] by (-1)

You can use a 'wait until' block, because the action only happens once. The 'forever if' block will keep repeating whatever code it contains when the condition is fulfilled. The forever THEN if blocks keeps checking whether the condition is fulfilled, then executes the script it contains. The 'wait until' block is pretty self-explanatory.

As for the broadcast problem, this is because a. you used a 'forever if' block, which will keep repeating itself, and b. you used a 'broadcast X' block instead of a 'broadcast X and wait' .
This means that as soon as Collected hit 0, the broadcast 'Collected' was being continuously sent out - the script didn't have time to finish and had to keep restarting.
If you only want the message to be displayed once, just use a 'wait until'. Otherwise, you could use a forever if, or:

when gf clicked

forever  

if <touching [Sprite1 v]?> 

change [Money v] by (House3)

set [House3 v] to [0]

change [Collected v] by (-1)

stop script

end

end

Good luck, and don't forget to add instructions on how to play in the project notes 

It's all fixed!